Add GOES example #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should I add the rechunked version as a second dataset in the same catalogue? |
We probably shouldn't include the GOES example as it only does 24 time steps. |
|
Can we make a bigger GOES, then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rsignell-usgs , what do you think? Note that I added some metadata. In a case like this, with a single reader in a catalog, it's not obvious whether the descriptive stuff belongs to the whole catalog, the data spec (i.e., URL) or the xarray-specific reader.
(side note: the storage options end up in the xarray kwargs, which is fine, but there is an argument that they are an inherent attribute of the data source, since using fsspec is the only way to do anything with the reference set)